chore(workflows): consolidate npm publishing into single-source version.yml#91
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23ada501a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --title "${TAG}" \ | ||
| --notes-file /tmp/release-notes.md | ||
| fi |
There was a problem hiding this comment.
After this change, the Release job ends immediately after gh release create, so manual runs (or any run where Resolve version derives a hotfix tag) now create a GitHub release without publishing the matching npm version. This is a regression from the previous workflow behavior and can leave v<version> tags discoverable in GitHub with no corresponding package on npm. version.yml does not backfill this path because its manual trigger publishes from dev (branch || 'dev') and its main publish path is gated to CI workflow_run merge commits from /dev.
Useful? React with 👍 / 👎.
2 participants
Consolidating all npm publishing logic into version.yml utilizing OIDC, eliminating redundant publish actions in CI and Release workflows to resolve publish failures.